Attention is currently required from: osmith, pespin.

View Change

2 comments:

• Patchset:

  • Patch Set #2:

    agreeing with all of pespin's comments

• File include/osmocom/bsc_nat/bsc_nat.h:

  • Patch Set #2, Line 48: uint32_t subscr_conn_id_next[2]; /* for CN, RAN */

    I'd simply have 2 variables here, looks easier to identify them in code, and I bet there's no real g […]

    one could even go one further and have sub-structs like

    struct bsc_nat {
            struct osmo_fsm_inst *fi;
            struct {
                    struct llist_heads mscs;
                    uint32_t subscr_conn_id_next;
            } cn;
            struct {
                    truct llist_head bscs;
                    uint32_t subscr_conn_id_next;
            } ran;
    }

    IMHO this way it's most clear what belongs where.

To view, visit change 27476. To unsubscribe, or for help writing mail filters, visit settings.