Attention is currently required from: fixeria, laforge, pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32552?usp=email )

Change subject: trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2) ......................................................................

Patch Set 3: Code-Review+1

(4 comments)

File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/5dab35f0_dbd09cfa PS1, Line 737:

I was thinking about this too. But this would make the logging/flow a bit confusing: […]

Done

https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/11319e4a_34c93535 PS1, Line 743: re-schedule last cmd in rc seconds time

Looks like I introduced related issues back in 4444262a6ab1e1e231ea81c4ec990f1a1f571a1f (https://ger […]

Done

File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/fe89a4de_7d8e07b8 PS3, Line 731: goto rsp_error; just to confirm, don't we need to reset `flushed_wile_in_trx_ctrl_read_cb` to `false` here?

https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/9b9642af_af8e78bd PS3, Line 738: return 0; just to confirm, don't we need to reset `flushed_wile_in_trx_ctrl_read_cb` to `false` here?