Attention is currently required from: fixeria, laforge, pespin.

Patch set 3:Code-Review +1

View Change

4 comments:

• File src/osmo-bts-trx/trx_if.c:

  • Patch Set #1, Line 737:

    I was thinking about this too. But this would make the logging/flow a bit confusing: […]

    Done

  • Patch Set #1, Line 743: re-schedule last cmd in rc seconds time

    Looks like I introduced related issues back in 4444262a6ab1e1e231ea81c4ec990f1a1f571a1f (https://ger […]

    Done

• File src/osmo-bts-trx/trx_if.c:

  • Patch Set #3, Line 731: goto rsp_error;

    just to confirm, don't we need to reset `flushed_wile_in_trx_ctrl_read_cb` to `false` here?

  • Patch Set #3, Line 738: return 0;

    just to confirm, don't we need to reset `flushed_wile_in_trx_ctrl_read_cb` to `false` here?

To view, visit change 32552. To unsubscribe, or for help writing mail filters, visit settings.