Attention is currently required from: Timur Davydov.

pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email )

Change subject: core: guard TCP stats on availability of linux/tcp.h and struct tcp_info ......................................................................

Patch Set 1:

(3 comments)

Patchset:

PS1: Since we are only talking about 2-3 public APIs, I think in this case it may make sense to wrap all of existing stats_tcp.c within a "if HAVE_LINUX_TCP_H", and then add a "else" section with stub functions for those public APIs, eg. _register() one returning -ENOTSUP.

File src/core/stats_tcp.c:

https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/76b3162b_6c153b40?u... : PS1, Line 315: osmo_timer_schedule(&stats_tcp_poll_timer, osmo_tcp_stats_config->interval, 0); I stats are not used, we should disable this too.

https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/f1a1f178_92b7975c?u... : PS1, Line 328: osmo_timer_setup(&stats_tcp_poll_timer, stats_tcp_poll_timer_cb, NULL); I stats are not used, we can disable this function completelly afaiu.