Attention is currently required from: Timur Davydov.
3 comments:
Patchset:
Since we are only talking about 2-3 public APIs, I think in this case it may make sense to wrap all of existing stats_tcp.c within a "if HAVE_LINUX_TCP_H", and then add a "else" section with stub functions for those public APIs, eg. _register() one returning -ENOTSUP.
File src/core/stats_tcp.c:
Patch Set #1, Line 315: osmo_timer_schedule(&stats_tcp_poll_timer, osmo_tcp_stats_config->interval, 0);
I stats are not used, we should disable this too.
Patch Set #1, Line 328: osmo_timer_setup(&stats_tcp_poll_timer, stats_tcp_poll_timer_cb, NULL);
I stats are not used, we can disable this function completelly afaiu.
To view, visit change 41922. To unsubscribe, or for help writing mail filters, visit settings.