Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31108 )

Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps. ......................................................................

Patch Set 6:

(5 comments)

Patchset:

PS6: The new approach is better, thanks!

File src/host/layer23/include/osmocom/bb/common/l23_app.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/a7162cb4_58671a10 PS2, Line 19: bts

Ack, I'll fix

Not addressed.

File src/host/layer23/src/common/main.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/04a63828_4a861830 PS6, Line 301: "Setting up GSMTAP Um forwarding to '%s:%u'\n", weird formatting, same above

File src/host/layer23/src/common/vty.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/70e02fd8_84f27ad9 PS6, Line 170: see also 'gsmtap / category could you clarify what you mean here?

https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/b9beea47_1258cc18 PS6, Line 188: TALLOC_FREE Isn't TALLOC_FREE macro NULL-safe, btw?