Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31108 ) Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps. ...................................................................... Patch Set 6: (5 comments) Patchset: PS6: The new approach is better, thanks! File src/host/layer23/include/osmocom/bb/common/l23_app.h: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/a7162cb4_58671a10 PS2, Line 19: bts Not addressed. File src/host/layer23/src/common/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/04a63828_4a861830 PS6, Line 301: "Setting up GSMTAP Um forwarding to '%s:%u'\n", weird formatting, same above File src/host/layer23/src/common/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/70e02fd8_84f27ad9 PS6, Line 170: see also 'gsmtap / category could you clarify what you mean here? https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/b9beea47_1258cc18 PS6, Line 188: TALLOC_FREE Isn't TALLOC_FREE macro NULL-safe, btw? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2582a1633d37d350a7f4c2bb5e03793bdf46e839 Gerrit-Change-Number: 31108 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Feb 2023 16:46:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment