Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 3: (5 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/d194fa9d_ead8e5e1 PS3, Line 11: and the BSC also must instruct the BTS to transmit the via PCH instead of "to transmit the via PCH" transmit the what? https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/27ae5f07_7bf71751 PS3, Line 14: This commit description seems to be saying that the fact that the DL TBF Imm Ass is sent over PDCH is ericsson specific. But it is actually not. Patchset: PS3: I am fine with keeping the 2 messages right now, but we should probably try to deprecate and eventually get rid of one of them (the one without TLLI?). We could even add a different primitive with specific uint16_t prgroup and uint32_t tlli fields to it. File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/bfb32eb7_feffed37 PS3, Line 1109: pcu_l1if_tx_pch_dt(tbf->tlli(), ms_paging_group(tbf_ms(tbf)), bts, immediate_assignment, plen); Please don't change the order of params between the 2 similar functions. pcu_l1if_tx_pch_dt(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf)), tbf->tlli()); File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/b943ff18_8c0f1b7f PS3, Line 312: uint8_t data[sizeof(tlli) + PAGING_GROUP_LEN + GSM_MACBLOCK_LEN]; const size_t pdu_len = sizeof(tlli) + PAGING_GROUP_LEN + GSM_MACBLOCK_LEN; Then you can use pdu_len below too. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Thu, 02 Feb 2023 16:48:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment