Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816 )
Change subject: add ps_rab_ass FSM to map GTP via UPF ......................................................................
Patch Set 2:
(15 comments)
File include/osmocom/hnbgw/hnbgw.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/44dd4d64_06a87c46 PS2, Line 193: /* Return true when the user configured GTP mapping to be enabled, by configuring a PFCP link to a UPF.
I'm not sure we really want to disable this feature. […]
I'm not following you, pau. Which feature do you want ot disable? The feature to use the external UPF for gtp-mapping? Or the feature to bypass that external UPF? I think there are valid use cases in both scenrarios.
Paging should not really be something the HNBGW has to decide upon, but the SGSN. The SGSN knows if there's an Iu connection or not, and it should know if it has to buffer packets and page, or if it can send them to the RNC/HNBGW. Am I missing something?
File include/osmocom/hnbgw/ps_rab_fsm.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/ef534e74_248fe3dd PS1, Line 8: struct addr_teid {
Maybe add a one line documenttion. […]
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/1ca2bfaf_e50eb34a PS1, Line 14: /* Two of this make up a GTP mapping, one for the Access (HNB) side, one for the Core (CN) side.
what does "this" mean here?
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/838fba43_cc60c991 PS1, Line 24: struct half_gtp_map {
gtp_tunnel would be accurate, except that the FAR (Forwarding Action Rule) is closely related to the […]
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/fd7653c5_5c0ab9f5 PS1, Line 36: /* Whether the RANAP message this RAB's remote address was obtained from encoded the address in x213_nsap */
it is accurate but i'll rephrase to less ambiguous grammar
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/bdd01c72_9849f2dd PS1, Line 41: struct osmo_fsm_inst *fi;
document the type of fsm? because I see 2 more "fi" below.
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/e779e32e_720d5540 PS1, Line 54: /* Backpointer to the ps_rab_ass_fsm for the RAB Assignment Request from Core that created this RAB. */
commenting in code...
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/e4a5f17e_840e6ad6 PS1, Line 79: bool ps_rab_is_established(struct ps_rab *rab);
constify param
Done
File src/osmo-hnbgw/hnbgw_cn.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/458a0325_19cfeaeb PS1, Line 373: if (!map->is_ps) {
we (i?) usually list CS above PS ... […]
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/d872ba4a_9e2f1532 PS1, Line 396: rc = ranap_ran_rx_co_decode(map, message, msgb_l2(oph->msg), msgb_l2len(oph->msg));
i think i even considered that when writing the patch, but left it like this to show that the CS cod […]
Done
File src/osmo-hnbgw/hnbgw_pfcp.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/30fc8785_d653f75b PS1, Line 77: if (!hnb_gw_is_gtp_mapping_enabled(hnb_gw)) {
that's a matter of taste ... […]
agrering with neels.
File src/osmo-hnbgw/hnbgw_rua.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/5eb6d23e_cfd6d3a0 PS1, Line 284: if (!map->is_ps) {
idk i like CS above PS better, also before this patch there was "!is_ps" above
Ack
File src/osmo-hnbgw/hnbgw_vty.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/26f2a5ee_7f01c55b PS1, Line 474: if (g_hnb_gw->config.pfcp.local_addr)
same order here as where the cmds are added to vty, but ok whatever
not aware of any specific ordering requirement.
File src/osmo-hnbgw/ps_rab_ass_fsm.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/24881181_99e8e8ef PS1, Line 490: /* See whether all RABs are done establishing, and replace RTP info in the RAB Assignment Response message, so that we
lol thx
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/9bf989a9_b05c7779 PS1, Line 625: void hnbgw_gtpmap_release(struct hnbgw_context_map *map)
I'm reading "gsmtap" all the time ;)
Done
-
laforge