Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816 ) Change subject: add ps_rab_ass FSM to map GTP via UPF ...................................................................... Patch Set 2: (15 comments) File include/osmocom/hnbgw/hnbgw.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/44dd4d64_06a87c46 PS2, Line 193: /* Return true when the user configured GTP mapping to be enabled, by configuring a PFCP link to a UPF. I'm not following you, pau. Which feature do you want ot disable? The feature to use the external UPF for gtp-mapping? Or the feature to bypass that external UPF? I think there are valid use cases in both scenrarios. Paging should not really be something the HNBGW has to decide upon, but the SGSN. The SGSN knows if there's an Iu connection or not, and it should know if it has to buffer packets and page, or if it can send them to the RNC/HNBGW. Am I missing something? File include/osmocom/hnbgw/ps_rab_fsm.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/ef534e74_248fe3dd PS1, Line 8: struct addr_teid { Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/1ca2bfaf_e50eb34a PS1, Line 14: /* Two of this make up a GTP mapping, one for the Access (HNB) side, one for the Core (CN) side. Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/838fba43_cc60c991 PS1, Line 24: struct half_gtp_map { Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/fd7653c5_5c0ab9f5 PS1, Line 36: /* Whether the RANAP message this RAB's remote address was obtained from encoded the address in x213_nsap */ Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/bdd01c72_9849f2dd PS1, Line 41: struct osmo_fsm_inst *fi; Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/e779e32e_720d5540 PS1, Line 54: /* Backpointer to the ps_rab_ass_fsm for the RAB Assignment Request from Core that created this RAB. */ Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/e4a5f17e_840e6ad6 PS1, Line 79: bool ps_rab_is_established(struct ps_rab *rab); Done File src/osmo-hnbgw/hnbgw_cn.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/458a0325_19cfeaeb PS1, Line 373: if (!map->is_ps) { Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/d872ba4a_9e2f1532 PS1, Line 396: rc = ranap_ran_rx_co_decode(map, message, msgb_l2(oph->msg), msgb_l2len(oph->msg)); Done File src/osmo-hnbgw/hnbgw_pfcp.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/30fc8785_d653f75b PS1, Line 77: if (!hnb_gw_is_gtp_mapping_enabled(hnb_gw)) { agrering with neels. File src/osmo-hnbgw/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/5eb6d23e_cfd6d3a0 PS1, Line 284: if (!map->is_ps) { Ack File src/osmo-hnbgw/hnbgw_vty.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/26f2a5ee_7f01c55b PS1, Line 474: if (g_hnb_gw->config.pfcp.local_addr) not aware of any specific ordering requirement. File src/osmo-hnbgw/ps_rab_ass_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/24881181_99e8e8ef PS1, Line 490: /* See whether all RABs are done establishing, and replace RTP info in the RAB Assignment Response message, so that we Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/9bf989a9_b05c7779 PS1, Line 625: void hnbgw_gtpmap_release(struct hnbgw_context_map *map) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic9bc30f322c4c6c6e82462d1da50cb15b336c63a Gerrit-Change-Number: 28816 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Jul 2022 11:45:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment