Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28205 )
Change subject: fix performance for chan_counts and all_allocated stats ......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/chan_counts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28205/comment/95eefb9a_08e9a2c4 PS1, Line 79: static const char *chan_counts_dim2_name[] = { looks like struct value_string?
https://gerrit.osmocom.org/c/osmo-bsc/+/28205/comment/c5367e55_8ac31103 PS1, Line 233: case NM_OC_RADIO_CARRIER: I guess this is to update when ts_is_usable (trx_is_usable()) changes.In that case you also need to tigger this when the BB_TRANSC object changes. And btw we have a better signal for that which you can probably use here: S_NM_RUNNING_CHG See the following commits: 50a42e7436db6e675d7e27b6fb1565d8f71ad03a 9f8137dc735d6da5be642ccbe90827de59841ac1 e6b8b8201a3b64d83896ef830fdb852a8397d08b
I don't see the need for triggering this when S_NM_STATECHG is received. Or you need that for the TS NM object? Maybe the best would be to implement the same logic for the nm_channel_fsm.c to also throw the S_NM_RUNNING_CHG for its object.