Attention is currently required from: neels.

View Change

2 comments:

• File src/osmo-bsc/chan_counts.c:

  • Patch Set #1, Line 79: static const char *chan_counts_dim2_name[] = {

    looks like struct value_string?

  • Patch Set #1, Line 233: case NM_OC_RADIO_CARRIER:

    I guess this is to update when ts_is_usable (trx_is_usable()) changes.In that case you also need to tigger this when the BB_TRANSC object changes.
    And btw we have a better signal for that which you can probably use here: S_NM_RUNNING_CHG
    See the following commits:
    50a42e7436db6e675d7e27b6fb1565d8f71ad03a
    9f8137dc735d6da5be642ccbe90827de59841ac1
    e6b8b8201a3b64d83896ef830fdb852a8397d08b

    I don't see the need for triggering this when S_NM_STATECHG is received. Or you need that for the TS NM object?
    Maybe the best would be to implement the same logic for the nm_channel_fsm.c to also throw the S_NM_RUNNING_CHG for its object.

To view, visit change 28205. To unsubscribe, or for help writing mail filters, visit settings.