Change in libosmocore[master]: rate_ctr: convert to timerfd - gerrit-log

30 Nov 2022


      Attention is currently required from: pespin, msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30302 )
Change subject: rate_ctr: convert to timerfd
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
File src/rate_ctr.c:
https://gerrit.osmocom.org/c/libosmocore/+/30302/comment/6968897a_b224adf2 
PS3, Line 359: 	timer_ticks++;
...
yes, but if a timer is lost due to the CPU being too loaded, you still want to tick the lost event I […]
I agree with pau.  I the "worst case" you can simply loop around the rate_ctr_group_intv(ctrg) below to make sure you call it expire_count times.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0
Gerrit-Change-Number: 30302
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: msuraev msuraev@sysmocom.de
Gerrit-Comment-Date: Wed, 30 Nov 2022 13:06:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: msuraev msuraev@sysmocom.de
Gerrit-MessageType: comment