Attention is currently required from: pespin, msuraev.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30303 )
Change subject: rate_ctr: use multiple timerfd
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
File src/rate_ctr.c:
https://gerrit.osmocom.org/c/libosmocore/+/30303/comment/37b32e72_f776b47e
PS3, Line 441: rc = rate_ctr_init_timer(&rate_ctr_timer_sec, &ts_interval_sec,
rate_ctr_timer_cb_sec);
Influence timer ordering? I don't understand your
question please rephrase.
the point is: if there is one (per-second) timer that
triggers all the updates, they are "atomic" from the point of stats/vty/ctrl
interface. But if there re multiple timers like in this patch, you introduce the problems
mentioned by pau. I tend to agree.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30303
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I78da7119bb745c38eed011b3a8452797a1bfe9d4
Gerrit-Change-Number: 30303
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Nov 2022 13:08:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment