Attention is currently required from: pespin, msuraev.

Patch set 5:Code-Review -1

View Change

1 comment:

• File src/rate_ctr.c:

  • Patch Set #3, Line 441: rc = rate_ctr_init_timer(&rate_ctr_timer_sec, &ts_interval_sec, rate_ctr_timer_cb_sec);

    Influence timer ordering? I don't understand your question please rephrase.

    the point is: if there is one (per-second) timer that triggers all the updates, they are "atomic" from the point of stats/vty/ctrl interface. But if there re multiple timers like in this patch, you introduce the problems mentioned by pau. I tend to agree.

To view, visit change 30303. To unsubscribe, or for help writing mail filters, visit settings.