Attention is currently required from: laforge.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33947 )

Change subject: llc: Introduce function to log XID fields and use upon Rx/Tx ......................................................................

Patch Set 3:

(1 comment)

File src/llc/llc_xid.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/33947/comment/46b698c5_c762a26a PS3, Line 325: void gprs_llc_dump_xid_fields(const struct gprs_llc_xid_field *xid_fields,

I think it would be better to have some kind of visual begin + end marker in the log, to clearly see […]

We have such markers (one being line and one end line) in osmo-pcu and I became to really dislike them tbh.

I think the format is good enough since they all start with "XID: type" which makes it easier to find out when they start and end. We can really improve the format a thousand ways whatever way we like later, for now it proved to be OK to show everything was being handled properly.

Moreover, I basically ported this function from osmo-sgsn, so I'da rather keep it similar for now.

TL;DR: I'm not against improving the format but we have more important parts in the stack where to invest the time & efforts.