Attention is currently required from: laforge.

View Change

1 comment:

• File src/llc/llc_xid.c:

  • Patch Set #3, Line 325: void gprs_llc_dump_xid_fields(const struct gprs_llc_xid_field *xid_fields,

    I think it would be better to have some kind of visual begin + end marker in the log, to clearly see […]

    We have such markers (one being line and one end line) in osmo-pcu and I became to really dislike them tbh.

    I think the format is good enough since they all start with "XID: type" which makes it easier to find out when they start and end. We can really improve the format a thousand ways whatever way we like later, for now it proved to be OK to show everything was being handled properly.

    Moreover, I basically ported this function from osmo-sgsn, so I'da rather keep it similar for now.

    TL;DR: I'm not against improving the format but we have more important parts in the stack where to invest the time & efforts.

To view, visit change 33947. To unsubscribe, or for help writing mail filters, visit settings.