Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36342?usp=email ) Change subject: e1line_dump_vty(): dump keepalive state and params ...................................................................... Patch Set 1: (2 comments) File src/e1_input_vty.c: https://gerrit.osmocom.org/c/libosmo-abis/+/36342/comment/32ca57ac_06e68e2b PS1, Line 460: static void e1line_ka_dump_vty(struct vty *vty, const struct e1inp_line *line) The problem here (in generic code path) is that you cannot make assumptions on what kind of transport is used by particular driver implementation. The Abis-over-IP is just one of the existing drivers. For instance, you don't have TCP on the E1 line. As far as I understand the abstraction layers, we just provide the driver with generic keepalive parameters. And `E1INP_USE_DEFAULT` means driver's default value. https://gerrit.osmocom.org/c/libosmo-abis/+/36342/comment/ac001228_2b74f123 PS1, Line 473: vty_out(vty, "(driver's default)"); See the comment above. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36342?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I17bd991850333ee794ab216f474b5e045fb01fa3 Gerrit-Change-Number: 36342 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Mar 2024 11:17:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment