Attention is currently required from: osmith.

View Change

2 comments:

• File src/e1_input_vty.c:

  • Patch Set #1, Line 460: static void e1line_ka_dump_vty(struct vty *vty, const struct e1inp_line *line)

    I would suggest making clear that this is TCP keepalive: […]

    The problem here (in generic code path) is that you cannot make assumptions on what kind of transport is used by particular driver implementation. The Abis-over-IP is just one of the existing drivers. For instance, you don't have TCP on the E1 line.

    As far as I understand the abstraction layers, we just provide the driver with generic keepalive parameters. And `E1INP_USE_DEFAULT` means driver's default value.

  • Patch Set #1, Line 473: vty_out(vty, "(driver's default)");

    (I see that it is in a different c file, still I think it would be useful to have the information th […]

    See the comment above.

To view, visit change 36342. To unsubscribe, or for help writing mail filters, visit settings.