Attention is currently required from: pespin, msuraev. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28844 )
Change subject: Introduce libsmpputil ......................................................................
Patch Set 11: Code-Review-1
(3 comments)
File tests/db_sms/Makefile.am:
https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/6a6a35bd_e8974102 PS11, Line 40: $(top_builddir)/src/libsmpputil/libsmpputil.a \ You now only build libsmpputil if BUILD_SMPP, but db_sms_test is built unconditionally.
make check now fails (if smpp is not enabled):
make sms_queue_test make[4]: Entering directory '/home/daniel/scm/osmo/osmo-msc/tests/sms_queue' make[4]: *** No rule to make target '../../src/libsmpputil/libsmpputil.a', needed by 'sms_queue_test'. Stop.
It seems like you don't need anything from libsmpputil, so just remove it. The test builds and passes here if I do that.
File tests/msc_vlr/Makefile.am:
https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/f8f46f77_fb1aff9f PS11, Line 35: $(top_builddir)/src/libsmpputil/libsmpputil.a \ Same
File tests/sms_queue/Makefile.am:
https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/a3bf8280_1404acdf PS11, Line 39: $(top_builddir)/src/libsmpputil/libsmpputil.a \ Same
-
daniel