Attention is currently required from: laforge, pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34223 )

Change subject: osmo_ortp: register a PayloadType for RTP_PT_CSDATA ......................................................................

Patch Set 1: Code-Review+2

(2 comments)

File src/trau/osmo_ortp.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/34223/comment/4873b6f0_8c7055b3 PS1, Line 42: static PayloadType *payload_type_clearmode;

I wonder why do we need all these static variables taking memory if they are not really used at all […]

TBH, I have no idea. We can try getting rid of them in a separate patch.

https://gerrit.osmocom.org/c/libosmo-abis/+/34223/comment/9e3017dd_72168a09 PS1, Line 307: rtp_profile_set_payload(osmo_pt_profile, RTP_PT_AMR, &payload_type_amr);

I'm unable to find where does payload_type_amr come from, I don't see it declared anywhere... […]

It's provided by libortp:

``` include/ortp/payloadtype.h:ORTP_VAR_PUBLIC PayloadType payload_type_amr; ```