Attention is currently required from: laforge, pespin.

Patch set 1:Code-Review +2

View Change

2 comments:

• File src/trau/osmo_ortp.c:

  • Patch Set #1, Line 42: static PayloadType *payload_type_clearmode;

    I wonder why do we need all these static variables taking memory if they are not really used at all […]

    TBH, I have no idea. We can try getting rid of them in a separate patch.

  • Patch Set #1, Line 307: rtp_profile_set_payload(osmo_pt_profile, RTP_PT_AMR, &payload_type_amr);

    I'm unable to find where does payload_type_amr come from, I don't see it declared anywhere... […]

    It's provided by libortp:

    ```
    include/ortp/payloadtype.h:ORTP_VAR_PUBLIC PayloadType payload_type_amr;
    ```

To view, visit change 34223. To unsubscribe, or for help writing mail filters, visit settings.