Attention is currently required from: fixeria, msuraev. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30262 )
Change subject: trxcon: implement Ready-to-Receive PHYIF API ......................................................................
Patch Set 2:
(1 comment)
File src/host/trxcon/src/sched_trx.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30262/comment/f1cb3baa_aad3999c PS2, Line 832: probe->flags |= L1SCHED_PROBE_F_ACTIVE; The unexpected part here is that is ors the flags.
I as the caller know this is the passed _output_ arg, so I expect the function to set it. Right now the caller needs to initialize the output arg so random crap does not get "or"ed, which is unexpected...