Attention is currently required from: fixeria, msuraev.

View Change

1 comment:

• File src/host/trxcon/src/sched_trx.c:

  • Patch Set #2, Line 832: probe->flags |= L1SCHED_PROBE_F_ACTIVE;

    The unexpected part here is that is ors the flags.

    I as the caller know this is the passed _output_ arg, so I expect the function to set it. Right now the caller needs to initialize the output arg so random crap does not get "or"ed, which is unexpected...

To view, visit change 30262. To unsubscribe, or for help writing mail filters, visit settings.