Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30568 )

Change subject: Get rid of tbf->first_ts ......................................................................

Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/30568/comment/a68d28c1_ec6c932c PS1, Line 9: quickly Not going to block you work, but are you sure this is not causing any noticeable performance regressions? Caching first_ts might have been done on purpose, e.g. to avoid iterating over the list of PDCHs in hot code paths. I am not familiar with the code base as good as you are, just making sure we're still good after this change.

File src/tbf.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/30568/comment/cf309207_34addf75 PS1, Line 899: 8

I don't really like the magic numbers. […]

Ack, ARRAY_SIZE(tbf->pdch) should work here.

https://gerrit.osmocom.org/c/osmo-pcu/+/30568/comment/f1a8654a_434daac8 PS1, Line 911: 8 Same here.