Attention is currently required from: laforge, pespin.
3 comments:
Commit Message:
Patch Set #1, Line 9: quickly
Not going to block you work, but are you sure this is not causing any noticeable performance regressions? Caching first_ts might have been done on purpose, e.g. to avoid iterating over the list of PDCHs in hot code paths. I am not familiar with the code base as good as you are, just making sure we're still good after this change.
File src/tbf.cpp:
I don't really like the magic numbers. […]
Ack, ARRAY_SIZE(tbf->pdch) should work here.
Same here.
To view, visit change 30568. To unsubscribe, or for help writing mail filters, visit settings.