laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26803 ) Change subject: gtp: Fix uninitialized var if no extension flags set in gtp header ...................................................................... gtp: Fix uninitialized var if no extension flags set in gtp header The logic was plain wrong, bug introduced while typing initial code. Closes: Coverity CID#243535 Change-Id: I497667edd0571fff91ab41c8b57bdcf277e5988d --- M src/osmo-hnodeb/gtp.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c index c22de65..ef12cf6 100644 --- a/src/osmo-hnodeb/gtp.c +++ b/src/osmo-hnodeb/gtp.c @@ -246,7 +246,7 @@ if (hdr->s || hdr->pn || hdr->e) opt_hdr_len = 4; - if (hdr->pn) + else opt_hdr_len = 0; if (msgb_length(msg) < sizeof(*hdr) + opt_hdr_len) { -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26803 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I497667edd0571fff91ab41c8b57bdcf277e5988d Gerrit-Change-Number: 26803 Gerrit-PatchSet: 1 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-MessageType: merged