laforge submitted this change.

View Change

gtp: Fix uninitialized var if no extension flags set in gtp header

The logic was plain wrong, bug introduced while typing initial code.

Closes: Coverity CID#243535
Change-Id: I497667edd0571fff91ab41c8b57bdcf277e5988d
---
M src/osmo-hnodeb/gtp.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c
index c22de65..ef12cf6 100644
--- a/src/osmo-hnodeb/gtp.c
+++ b/src/osmo-hnodeb/gtp.c
@@ -246,7 +246,7 @@
 
 	if (hdr->s || hdr->pn || hdr->e)
 		opt_hdr_len = 4;
-	if (hdr->pn)
+	else
 		opt_hdr_len = 0;
 
 	if (msgb_length(msg) < sizeof(*hdr) + opt_hdr_len) {

To view, visit change 26803. To unsubscribe, or for help writing mail filters, visit settings.