Attention is currently required from: laforge, neels, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email )
Change subject: ecu: fix alignment of fr_ecu_state ......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/35212/comment/3a391b30_23de5c8b PS5, Line 7: ecu: force alignment of member data in struct osmo_ecu_state
you probably need to update the whole commit description since the approach changed.
I have now fixed it (hopefully). The description of the is-situation should still apply.
File src/codec/ecu_fr.c:
https://gerrit.osmocom.org/c/libosmocore/+/35212/comment/028d33bb_1cf98811 PS4, Line 92: struct osmo_ecu_state ecu_state;
Add a comment that ecu_state should be the first in the struct. […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/35212/comment/3f5335ac_fffc3a17 PS4, Line 294: return (struct osmo_ecu_state*) fr;
Ah sorry, not in this precise line. But here it's simply a matter of doing: […]
Done
File src/codec/ecu_fr.c:
https://gerrit.osmocom.org/c/libosmocore/+/35212/comment/781858f8_fd64fa1e PS5, Line 315: struct fr_ecu_state *fr = (struct fr_ecu_state *) st;
It removes the need of having one struct being the first field of the other one, plus avoid having p […]
Done
-
dexter