Attention is currently required from: laforge, neels, pespin.

View Change

4 comments:

• Commit Message:

  • Patch Set #5, Line 7: ecu: force alignment of member data in struct osmo_ecu_state

    you probably need to update the whole commit description since the approach changed.

    I have now fixed it (hopefully). The description of the is-situation should still apply.

• File src/codec/ecu_fr.c:

  • Patch Set #4, Line 92: struct osmo_ecu_state ecu_state;

    Add a comment that ecu_state should be the first in the struct. […]

    Done

  • Patch Set #4, Line 294: return (struct osmo_ecu_state*) fr;

    Ah sorry, not in this precise line. But here it's simply a matter of doing: […]

    Done

• File src/codec/ecu_fr.c:

  • Patch Set #5, Line 315: struct fr_ecu_state *fr = (struct fr_ecu_state *) st;

    It removes the need of having one struct being the first field of the other one, plus avoid having p […]

    Done

To view, visit change 35212. To unsubscribe, or for help writing mail filters, visit settings.