Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31034 )
Change subject: Add setting of Sa bits to misdn driver ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/input/misdn.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/31034/comment/55135a14_c2471563 PS3, Line 300: struct e1inp_ts *e1i_ts = &line->ts[16-1];
what's this 16-1? isn't there some descriptivie define for it?
it's everywhere in the e1_input code. usable E1 timeslots count from 1..31 as TS0 is used for framing + CRC4. Our libosmo-abis timeslot array is indexed from zero, so timeslot 1 becomes index 0. Nothing unusual here, matches existing code.
-
laforge