Attention is currently required from: jolly, pespin.
Patch set 5:Code-Review +1
View Change
1 comment:
File src/input/misdn.c:
Patch Set #3, Line 300: struct e1inp_ts *e1i_ts = &line->ts[16-1];
what's this 16-1? isn't there some descriptivie define for it?
it's everywhere in the e1_input code. usable E1 timeslots count from 1..31 as TS0 is used for framing + CRC4. Our libosmo-abis timeslot array is indexed from zero, so timeslot 1 becomes index 0. Nothing unusual here, matches existing code.
To view, visit change 31034. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I54205a2534a7638cc071888d853f9d6d312dc9f0
Gerrit-Change-Number: 31034
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Feb 2023 11:58:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment