Attention is currently required from: jolly, pespin.

fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email )

Change subject: S1GW tests: Add test cases for S1 handover procedure ......................................................................

Patch Set 1:

(15 comments)

Patchset:

PS1: You're adding new testcases, so please edit `s1gw/expected-results.xml` accordingly.

Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/7c8ce8c9_418ad... : PS1, Line 9: preperation prepare, not prepere

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/0b464bca_39593... : PS1, Line 12: Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7 `Related: SYS#7309`

File s1gw/S1GW_ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/6f5bd778_88846... : PS1, Line 76: /* PLMNidentity */ '62F210'O,

you know you can assign by field name instead of commenting all of them? […]

Ack, let's please use field names here.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/f989c95b_9ac5b... : PS1, Line 1072: function f_ConnHdlr_tx_handover_req(in ERabList erabs,

either add in to all params or to none. […]

I intentionally use `in` / `out` in this API to clearly indicate whether the given E-RAB list is to be modified or to remain unchanged. For the `MME_UE_S1AP_ID` it does not really matter and I like the way it is. It's consistent with the existing code (for instance, see `f_ConnHdlr_{tx,rx}_initial_ctx_setup_rsp()`).

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/1e576a5f_449a9... : PS1, Line 1090: items[i] := ts_E_RABToBeSetupListHOReq(item)[0];

see the problem I mentioned in the previous commit? You end up doing weird stuff with [0] because yo […]

As explained in the previous commit, it's not possible to define the templates for a single item. This is why we have this hack here (and in the other existing functions too).

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/07dba3f4_d2dc0... : PS1, Line 1115: item := tr_E_RABToBeSetupItemHOReq(rab_id := erabs[i].erab_id, cosmetic: alignment issues

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/603cf104_93973... : PS1, Line 1185: in ERabList erabs Unused argument, not needed here.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/ddae016e_69bbf... : PS1, Line 1197: in ERabList erabs Unused argument, not needed here.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/d84f913a_3790a... : PS1, Line 1207: ts_TargetID `tr_TargetID` (receive template, not send).

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/f2b4e16a_3e7eb... : PS1, Line 1629: MME_UE_S1AP_ID mme_ue_id) cosmetic: alignment issues

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/97024f96_48c1d... : PS1, Line 1678: inout ERabList erabs This function does not modify the given list, so it should be `in`.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/5cf3f587_a363b... : PS1, Line 1693: inout ERabList erabs This function does not modify the given list, so it should be `in`.

File s1gw/S1GW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/99189321_8cb9e... : PS1, Line 872: Handover Request I would say "Handover Preparation procedures" here.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/e6e0872c_81e89... : PS1, Line 873: preperation "prepare", not "prepere"