Attention is currently required from: jolly, pespin.

View Change

15 comments:

• Patchset:

  • Patch Set #1:

    You're adding new testcases, so please edit `s1gw/expected-results.xml` accordingly.

• Commit Message:

  • Patch Set #1, Line 9: preperation

    prepare, not prepere

  • Patch Set #1, Line 12: Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7

    `Related: SYS#7309`

• File s1gw/S1GW_ConnHdlr.ttcn:

  • Patch Set #1, Line 76: /* PLMNidentity */ '62F210'O,

    you know you can assign by field name instead of commenting all of them? […]

    Ack, let's please use field names here.

  • Patch Set #1, Line 1072: function f_ConnHdlr_tx_handover_req(in ERabList erabs,

    either add in to all params or to none. […]

    I intentionally use `in` / `out` in this API to clearly indicate whether the given E-RAB list is to be modified or to remain unchanged. For the `MME_UE_S1AP_ID` it does not really matter and I like the way it is. It's consistent with the existing code (for instance, see `f_ConnHdlr_{tx,rx}_initial_ctx_setup_rsp()`).

  • Patch Set #1, Line 1090: items[i] := ts_E_RABToBeSetupListHOReq(item)[0];

    see the problem I mentioned in the previous commit? You end up doing weird stuff with [0] because yo […]

    As explained in the previous commit, it's not possible to define the templates for a single item. This is why we have this hack here (and in the other existing functions too).

  • Patch Set #1, Line 1115: item := tr_E_RABToBeSetupItemHOReq(rab_id := erabs[i].erab_id,

    cosmetic: alignment issues

  • Patch Set #1, Line 1185: in ERabList erabs

    Unused argument, not needed here.

  • Patch Set #1, Line 1197: in ERabList erabs

    Unused argument, not needed here.

  • Patch Set #1, Line 1207: ts_TargetID

    `tr_TargetID` (receive template, not send).

  • Patch Set #1, Line 1629: MME_UE_S1AP_ID mme_ue_id)

    cosmetic: alignment issues

  • Patch Set #1, Line 1678: inout ERabList erabs

    This function does not modify the given list, so it should be `in`.

  • Patch Set #1, Line 1693: inout ERabList erabs

    This function does not modify the given list, so it should be `in`.

• File s1gw/S1GW_Tests.ttcn:

  • Patch Set #1, Line 872: Handover Request

    I would say "Handover Preparation procedures" here.

  • Patch Set #1, Line 873: preperation

    "prepare", not "prepere"

To view, visit change 41009. To unsubscribe, or for help writing mail filters, visit settings.