[L] Change in osmo-ttcn3-hacks[master]: S1GW tests: Add test cases for S1 handover procedure - gerrit-log

8 Sep 2025

Attention is currently required from: fixeria, pespin.

jolly has posted comments on this change by jolly. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email )

Change subject: S1GW tests: Add test cases for S1 handover procedure
......................................................................

Patch Set 1:

(14 comments)

Patchset:

PS1: 
...
  You're adding new testcases, so please edit
`s1gw/expected-results.xml` accordingly. Done

Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/125200c8_ab91…
:
PS1, Line 9: preperation
...
  prepare, not prepere Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/e900f8bb_eed9…
:
PS1, Line 12: Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7
...
  `Related: SYS#7309` Done

File s1gw/S1GW_ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/48079bf9_0fa8…
:
PS1, Line 71: template TargetID
...
  const c_TargetID Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/760ad866_2470…
:
PS1, Line 76: 			/* PLMNidentity */ '62F210'O,
...
  Ack, let's please use field names here.
Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/b27cca8e_eea6…
:
PS1, Line 1115: 		item := tr_E_RABToBeSetupItemHOReq(rab_id := erabs[i].erab_id,
...
  cosmetic: alignment issues Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/38a7f95a_45c7…
:
PS1, Line 1185: in ERabList erabs
...
  Unused argument, not needed here. Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/c07daa34_791d…
:
PS1, Line 1197: in ERabList erabs
...
  Unused argument, not needed here. Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/6e106b36_c207…
:
PS1, Line 1207: ts_TargetID
...
  `tr_TargetID` (receive template, not send).
Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/1a3b070a_e559…
:
PS1, Line 1629: 					  MME_UE_S1AP_ID mme_ue_id)
...
  cosmetic: alignment issues Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/f06a167e_e10c…
:
PS1, Line 1678: inout ERabList erabs
...
  This function does not modify the given list, so it
should be `in`. Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/82934de1_d147…
:
PS1, Line 1693: inout ERabList erabs
...
  This function does not modify the given list, so it
should be `in`. Done

File s1gw/S1GW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/db866013_2857…
:
PS1, Line 872: Handover Request
...
  I would say "Handover Preparation
procedures" here. Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/744937ea_92b2…
:
PS1, Line 873: preperation
...
  "prepare", not "prepere"
Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7
Gerrit-Change-Number: 41009
Gerrit-PatchSet: 1
Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 08 Sep 2025 13:36:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;