Attention is currently required from: fixeria, pespin.

14 comments:

Patchset:
- Patch Set #1:
  You're adding new testcases, so please edit `s1gw/expected-results.xml` accordingly.
  Done
Commit Message:
- Patch Set #1, Line 9: preperation
  prepare, not prepere
  Done
- Patch Set #1, Line 12: Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7
  `Related: SYS#7309`
  Done
File s1gw/S1GW_ConnHdlr.ttcn:
- Patch Set #1, Line 71: template TargetID
  const c_TargetID
  Done
- Patch Set #1, Line 76: /* PLMNidentity */ '62F210'O,
  Ack, let's please use field names here.
  Done
- Patch Set #1, Line 1115: item := tr_E_RABToBeSetupItemHOReq(rab_id := erabs[i].erab_id,
  cosmetic: alignment issues
  Done
- Patch Set #1, Line 1185: in ERabList erabs
  Unused argument, not needed here.
  Done
- Patch Set #1, Line 1197: in ERabList erabs
  Unused argument, not needed here.
  Done
- Patch Set #1, Line 1207: ts_TargetID
  `tr_TargetID` (receive template, not send).
  Done
- Patch Set #1, Line 1629: MME_UE_S1AP_ID mme_ue_id)
  cosmetic: alignment issues
  Done
- Patch Set #1, Line 1678: inout ERabList erabs
  This function does not modify the given list, so it should be `in`.
  Done
- Patch Set #1, Line 1693: inout ERabList erabs
  This function does not modify the given list, so it should be `in`.
  Done
File s1gw/S1GW_Tests.ttcn:
- Patch Set #1, Line 872: Handover Request
  I would say "Handover Preparation procedures" here.
  Done
- Patch Set #1, Line 873: preperation
  "prepare", not "prepere"
  Done

To view, visit change 41009. To unsubscribe, or for help writing mail filters, visit settings.