Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29285 ) Change subject: Introduce Osmux support ...................................................................... Patch Set 1: (8 comments) Patchset: PS1: The user manual needs to be updated to `include::{commondir}/chapters/osmux/osmux.adoc[]` from osmo-gsm-manuals.git, like it's done in osmo-bsc.git. Can be done in a separate change though. File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/85a892fb_0b3162b6 PS1, Line 1624: { cosmetic: no need for curly braces here File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/653c4a48_0b55fefb PS1, Line 1: libosmocore logging support copy-paste https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/78fd27bb_ede36a1e PS1, Line 43: (OSMUX_CID_MAX + 1 + 7) / 8 OSMO_BYTES_FOR_BITS(OSMUX_CID_MAX + 1) https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/302c3bab_c916ef4b PS1, Line 47: () void https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/670eb0db_3829f32c PS1, Line 183: osmux_handle_lookup _find_or_create() better reflects what this function does. https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/75790535_ae117981 PS1, Line 234: /* TS0..3 */ This is not true, remove this comment. https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/c40f0cff_f712628f PS1, Line 293: not needed? This needs to be resolved before merging this change, or at least marked as FIXME. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib80be434c06d07b3611bd18ae25dff8b14a7aad9 Gerrit-Change-Number: 29285 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Sep 2022 08:20:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment