Attention is currently required from: pespin.

View Change

8 comments:

• Patchset:

  • Patch Set #1:

    The user manual needs to be updated to `include::{commondir}/chapters/osmux/osmux.adoc[]` from osmo-gsm-manuals.git, like it's done in osmo-bsc.git. Can be done in a separate change though.

• File src/common/l1sap.c:

  • Patch Set #1, Line 1624: {

    cosmetic: no need for curly braces here

• File src/common/osmux.c:

  • Patch Set #1, Line 1: libosmocore logging support

    copy-paste

  • Patch Set #1, Line 43: (OSMUX_CID_MAX + 1 + 7) / 8

    OSMO_BYTES_FOR_BITS(OSMUX_CID_MAX + 1)

  • Patch Set #1, Line 47: ()

    void

  • Patch Set #1, Line 183: osmux_handle_lookup

    _find_or_create() better reflects what this function does.

  • Patch Set #1, Line 234: /* TS0..3 */

    This is not true, remove this comment.

  • Patch Set #1, Line 293: not needed?

    This needs to be resolved before merging this change, or at least marked as FIXME.

To view, visit change 29285. To unsubscribe, or for help writing mail filters, visit settings.