Attention is currently required from: manawyrm. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34457?usp=email ) Change subject: gsmtap.h: Add definitions for ISDN PPP sub-type ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: as there is both synchronous PPP over ISDN (the one you're describing here, where the HDLC around the PPP is directly in the B channel) as well as asynchronous PPP over ISDN (e.g. inside X.75), it might be best to indicate which is being talked about here. Maybe even reference https://www.rfc-editor.org/rfc/rfc1618.html ? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34457?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I17137167b2c74b6c5e53459743b6e140fc1a4386 Gerrit-Change-Number: 34457 Gerrit-PatchSet: 2 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Comment-Date: Tue, 19 Sep 2023 10:34:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment