Attention is currently required from: manawyrm.
Patch set 2:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #2:
as there is both synchronous PPP over ISDN (the one you're describing here, where the HDLC around the PPP is directly in the B channel) as well as asynchronous PPP over ISDN (e.g. inside X.75), it might be best to indicate which is being talked about here. Maybe even reference https://www.rfc-editor.org/rfc/rfc1618.html ?
To view, visit change 34457. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I17137167b2c74b6c5e53459743b6e140fc1a4386
Gerrit-Change-Number: 34457
Gerrit-PatchSet: 2
Gerrit-Owner: manawyrm <osmocom.account@tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: manawyrm <osmocom.account@tbspace.de>
Gerrit-Comment-Date: Tue, 19 Sep 2023 10:34:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment