Attention is currently required from: dotsimon, lynxis lazus, pespin. fixeria has posted comments on this change by dotsimon. ( https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email ) Change subject: Include SM-RP-UI in outgoing GSUP message when presesnt ...................................................................... Patch Set 3: Code-Review+1 (4 comments) Patchset: PS3: Thanks for the patch! Looks good to me. Just a few nitpicks... File include/osmocom/msc/gsm_04_11_gsup.h: https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/eea6a8c9_384784cb?usp… : PS3, Line 15: uint8_t *ui_buf `const` https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/db150c7d_ba86916d?usp… : PS3, Line 15: uint8_t ui_len, uint8_t *ui_buf To keep it consistent with existing API (e.g. `gsm411_gsup_mo_fwd_sm_req()`), let's please have `const uint8_t *ui_buf` first followed by `uint8_t ui_buf_len` (swap them). https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/02c82ca0_429feca8?usp… : PS3, Line 17: uint8_t *ui_buf `const` -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I90a607900ac7c86b200c79b7e8c460d4cbb3c3ce Gerrit-Change-Number: 39428 Gerrit-PatchSet: 3 Gerrit-Owner: dotsimon <implorable-herd(a)yahoo.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dotsimon <implorable-herd(a)yahoo.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 30 Jan 2025 10:54:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes