Attention is currently required from: dotsimon, lynxis lazus, pespin.

Patch set 3:Code-Review +1

View Change

4 comments:

• Patchset:

  • Patch Set #3:

    Thanks for the patch! Looks good to me. Just a few nitpicks...

• File include/osmocom/msc/gsm_04_11_gsup.h:

  • Patch Set #3, Line 15: uint8_t *ui_buf

    `const`

  • Patch Set #3, Line 15: uint8_t ui_len, uint8_t *ui_buf

    To keep it consistent with existing API (e.g. `gsm411_gsup_mo_fwd_sm_req()`), let's please have `const uint8_t *ui_buf` first followed by `uint8_t ui_buf_len` (swap them).

  • Patch Set #3, Line 17: uint8_t *ui_buf

    `const`

To view, visit change 39428. To unsubscribe, or for help writing mail filters, visit settings.