Attention is currently required from: kirr.

pespin has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email )

Change subject: trx_toolkit/*: Try to avoid copying burst data where possible ......................................................................

Patch Set 1: Code-Review+1

(2 comments)

File src/target/trx_toolkit/data_msg.py:

https://gerrit.osmocom.org/c/osmocom-bb/+/39537/comment/5c08da22_a5c2e889?us... : PS1, Line 230: msg_burst = memoryview(msg)[self.HDR_LEN:] Not sure if it's really noticeable, you may even skip the memoryview/slice here by checking:

if len(msg) == self.HDR_LEN: self.burst = None return msg_burst = memoryview(msg)[self.HDR_LEN:] self.parse_burst(msg_burst)

https://gerrit.osmocom.org/c/osmocom-bb/+/39537/comment/988ed215_075ad04d?us... : PS1, Line 336: burst = burst[:EDGE_BURST_LEN] Can you maybe use the memoryview() thing here too?