Attention is currently required from: kirr.

Patch set 1:Code-Review +1

View Change

2 comments:

• File src/target/trx_toolkit/data_msg.py:

  • Patch Set #1, Line 230: msg_burst = memoryview(msg)[self.HDR_LEN:]

    Not sure if it's really noticeable, you may even skip the memoryview/slice here by checking:

        if len(msg) == self.HDR_LEN:
            self.burst = None
            return
        msg_burst = memoryview(msg)[self.HDR_LEN:]
        self.parse_burst(msg_burst)

  • Patch Set #1, Line 336: burst = burst[:EDGE_BURST_LEN]

    Can you maybe use the memoryview() thing here too?

To view, visit change 39537. To unsubscribe, or for help writing mail filters, visit settings.