Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40590?usp=email )

Change subject: tests: add a simple gtpie_getie() test ......................................................................

Patch Set 1:

(23 comments)

File tests/gtp/gtpie_test.c:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/b2794e45_af5c9c34?usp... : PS1, Line 111: static void test_gtpie_getie() Bad function definition - void test_gtpie_getie() should probably be void test_gtpie_getie(void)

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/457aad52_095f9d08?usp... : PS1, Line 113: union gtpie_member *ie[GTPIE_SIZE] = {}; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/9f37ec03_0893d11b?usp... : PS1, Line 114: union gtpie_member ie_elem[3] = {}; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/4751c979_fc7921cc?usp... : PS1, Line 119: OSMO_ASSERT(gtpie_getie(ie, 0, 0) == -1); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/8bd3ae83_4fc4d012?usp... : PS1, Line 120: OSMO_ASSERT(gtpie_getie(ie, 0, 1) == -1); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/12e5aad1_6ab5f007?usp... : PS1, Line 122: OSMO_ASSERT(gtpie_getie(ie, GTPIE_ENODEB_ID, 0) == -1); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/afe66bb9_83385a95?usp... : PS1, Line 123: OSMO_ASSERT(gtpie_getie(ie, GTPIE_ENODEB_ID, 1) == -1); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/d954347a_a69f9de2?usp... : PS1, Line 125: ie_elem[0].tv1.t = GTPIE_CAUSE; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/6a84d657_4f3bf3be?usp... : PS1, Line 126: ie_elem[0].tv1.v = GTPIE_CAUSE; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/e0681b23_95d4169f?usp... : PS1, Line 127: ie[0] = &ie_elem[0]; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/fa19a7b3_2798c632?usp... : PS1, Line 129: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/4d0218ce_ed6ec516?usp... : PS1, Line 130: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == -1); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/b02dbe98_2bd2b652?usp... : PS1, Line 133: ie_elem[1].tv1.t = GTPIE_CAUSE; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/238b4612_5ba7c09b?usp... : PS1, Line 134: ie_elem[1].tv1.v = GTPIE_CAUSE; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/b08e47b7_d3e77350?usp... : PS1, Line 135: ie[2] = &ie_elem[0]; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/b40a78b9_91598954?usp... : PS1, Line 137: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/7fa6eba9_3878deb1?usp... : PS1, Line 138: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == 2); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/8b35a5f2_ee7e7c53?usp... : PS1, Line 141: ie_elem[2].tv1.t = GTPIE_CAUSE; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/11452f11_3c65064e?usp... : PS1, Line 142: ie_elem[2].tv1.v = GTPIE_CAUSE; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/af7645e1_ce558e06?usp... : PS1, Line 143: ie[GTPIE_SIZE - 1] = &ie_elem[0]; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/48eef148_3b2eb26f?usp... : PS1, Line 145: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/4364a93e_f1fdf8cf?usp... : PS1, Line 146: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == 2); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/35899a65_c7fededf?usp... : PS1, Line 147: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 2) == GTPIE_SIZE - 1); please, no spaces at the start of a line