View Change

23 comments:

• File tests/gtp/gtpie_test.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 111: static void test_gtpie_getie()

    Bad function definition - void test_gtpie_getie() should probably be void test_gtpie_getie(void)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 113: union gtpie_member *ie[GTPIE_SIZE] = {};

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 114: union gtpie_member ie_elem[3] = {};

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 119: OSMO_ASSERT(gtpie_getie(ie, 0, 0) == -1);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 120: OSMO_ASSERT(gtpie_getie(ie, 0, 1) == -1);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 122: OSMO_ASSERT(gtpie_getie(ie, GTPIE_ENODEB_ID, 0) == -1);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 123: OSMO_ASSERT(gtpie_getie(ie, GTPIE_ENODEB_ID, 1) == -1);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 125: ie_elem[0].tv1.t = GTPIE_CAUSE;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 126: ie_elem[0].tv1.v = GTPIE_CAUSE;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 127: ie[0] = &ie_elem[0];

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 129: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 130: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == -1);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 133: ie_elem[1].tv1.t = GTPIE_CAUSE;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 134: ie_elem[1].tv1.v = GTPIE_CAUSE;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 135: ie[2] = &ie_elem[0];

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 137: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 138: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == 2);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 141: ie_elem[2].tv1.t = GTPIE_CAUSE;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 142: ie_elem[2].tv1.v = GTPIE_CAUSE;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 143: ie[GTPIE_SIZE - 1] = &ie_elem[0];

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 145: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 146: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == 2);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 147: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 2) == GTPIE_SIZE - 1);

    please, no spaces at the start of a line

To view, visit change 40590. To unsubscribe, or for help writing mail filters, visit settings.