Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28602 ) Change subject: Add initial SBc-AP support to osmo-cbc ...................................................................... Patch Set 8: (5 comments) File src/sbcap_msg.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/cc78977e_1ac88c92 PS8, Line 40: #if 0 Because it shows how to encode a list of items when we add support for it in the future. This took me a while to figure out so it's worth keeping here. File src/sbcap_server.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/cfdc5a74_2c558631 PS8, Line 184: /* FIXME */ It's just kept to be on par with CBSP code, so that it can be fixed/figured out together later. File src/sbcap_server_fsm.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/834daff1_4bea79b4 PS8, Line 78: //pdu = data; Not needed yet, but it's still worth leaving it commented out so that readers know which pointer is being passed. https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/8e04db8c_a1d129c4 PS8, Line 148: /* static const long asn_VAL_1_SBcAP_id_Message_Identifier = 5; */ I left it on purpose, to understand what's this 5. ASN1C is not properly exporting those values, that's why I'm leaving the comments here and other parts, so that we can fix it later. File src/smscb_peer_fsm.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/57eb4439_0748b1d7 PS8, Line 311: //SBcAP_SBC_AP_PDU_t *pdu = NULL; Same, it's useful to keep for further future development. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9 Gerrit-Change-Number: 28602 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Jul 2022 09:35:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment