Attention is currently required from: osmith, fixeria.

View Change

5 comments:

• File src/sbcap_msg.c:

  • Patch Set #8, Line 40: #if 0

    There are multiple "if 0" style commented out code blocks below. […]

    Because it shows how to encode a list of items when we add support for it in the future. This took me a while to figure out so it's worth keeping here.

• File src/sbcap_server.c:

  • Patch Set #8, Line 184: /* FIXME */

    unresolved fixme, should it return here?

    It's just kept to be on par with CBSP code, so that it can be fixed/figured out together later.

• File src/sbcap_server_fsm.c:

  • Patch Set #8, Line 78: //pdu = data;

    not needed?

    Not needed yet, but it's still worth leaving it commented out so that readers know which pointer is being passed.

  • Patch Set #8, Line 148: /* static const long asn_VAL_1_SBcAP_id_Message_Identifier = 5; */

    remove?

    I left it on purpose, to understand what's this 5. ASN1C is not properly exporting those values, that's why I'm leaving the comments here and other parts, so that we can fix it later.

• File src/smscb_peer_fsm.c:

  • Patch Set #8, Line 311: //SBcAP_SBC_AP_PDU_t *pdu = NULL;

    remove? also "//pdu = data" twice below, also in smscb_p_fsm_wait_delete_ack

    Same, it's useful to keep for further future development.

To view, visit change 28602. To unsubscribe, or for help writing mail filters, visit settings.