Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email )
Change subject: Introduce tests/osmo-config-merge testsuite ......................................................................
Patch Set 4:
(2 comments)
File tests/osmo-config-merge/atlocal.in:
PS4:
do we need this empty file?
Yes, otherwise it failed when generating stuff iirc at configure time.
File tests/osmo-config-merge/testA.ok:
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/1f969dcf_2fd53942?u... : PS4, Line 74: power-ramp step-size 8000 mdB : power-ramp step-interval 1 : phy 0 instance 0 : power-ramp step-size 2000 mdB
is this correct? I would have expected that the new power-ramp step-size overwrites the previous one
Yes it's correct afaict, osmo-config-merge doesn't know about vty command internals and hence cannot know if 2 commands which are different test can actually be replaced.
-
pespin