Attention is currently required from: fixeria, osmith.

View Change

2 comments:

• File tests/osmo-config-merge/atlocal.in:

  • Patch Set #4:

    do we need this empty file?

    Yes, otherwise it failed when generating stuff iirc at configure time.

• File tests/osmo-config-merge/testA.ok:

  • Patch Set #4, Line 74:

      power-ramp step-size 8000 mdB
      power-ramp step-interval 1
      phy 0 instance 0
      power-ramp step-size 2000 mdB
    

    is this correct? I would have expected that the new power-ramp step-size overwrites the previous one

    Yes it's correct afaict, osmo-config-merge doesn't know about vty command internals and hence cannot know if 2 commands which are different test can actually be replaced.

To view, visit change 40295. To unsubscribe, or for help writing mail filters, visit settings.