Attention is currently required from: jolly, laforge, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email )
Change subject: stream_cli: Call read callback even if connection failed
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
File src/stream_cli.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/36020/comment/5ac09234_6c6e0296
PS6, Line 448: /* Forward message to read callback, also if the connection failed. */
Not sure why this is necessary - cli->disconnect_cb() called by osmo_stream_cli_reconnect() above already notifies the client of the disconnect.
The read/msgb will be empty anyway.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie2335987c38863bad5de1d2d4dbdf4c8373f927f
Gerrit-Change-Number: 36020
Gerrit-PatchSet: 6
Gerrit-Owner: jolly
andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 04 Mar 2024 16:27:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment