Attention is currently required from: jolly, laforge, pespin.
Patch set 6:Code-Review -1
View Change
1 comment:
File src/stream_cli.c:
Patch Set #6, Line 448: /* Forward message to read callback, also if the connection failed. */
Not sure why this is necessary - cli->disconnect_cb() called by osmo_stream_cli_reconnect() above already notifies the client of the disconnect.
The read/msgb will be empty anyway.
To view, visit change 36020. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie2335987c38863bad5de1d2d4dbdf4c8373f927f
Gerrit-Change-Number: 36020
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 16:27:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment